[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJHCu1K-gFnt2mR6LkP=BH-eB-cHUoPyWWGCgPNe7B1B4no8Sg@mail.gmail.com>
Date: Sat, 24 Mar 2018 14:21:53 +0100
From: Salvatore Mesoraca <s.mesoraca16@...il.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: linux-kernel@...r.kernel.org,
Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-crypto@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>, Kees Cook <keescook@...omium.org>,
Eric Biggers <ebiggers3@...il.com>
Subject: Re: [PATCH v2] crypto: ctr - avoid VLA use
2018-03-23 16:36 GMT+01:00 Herbert Xu <herbert@...dor.apana.org.au>:
> On Thu, Mar 15, 2018 at 12:18:58PM +0100, Salvatore Mesoraca wrote:
>>
>> +#define MAX_BLOCKSIZE 16
>> +
>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>> +#define MAX_ALIGNMASK 15
>> +#else
>> +#define MAX_ALIGNMASK 0
>> +#endif
>> +
>
> Hmm, this won't work. Just because you have efficient unaligned
> access in general doesn't mean that every implementation can live
> with unaligned access. In particular, on x86 there are quite a
> few implementations that require alignment or they will fault.
>
> So please just make it 15 unconditionally.
Oh, thank you for pointing it out. I'll fix this in v3.
Salvatore
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
