[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJHCu1LOhCcCcYqbKWFi1ac+raxoHGm75Y_njGHQD=S+9ZE1Xg@mail.gmail.com>
Date: Wed, 14 Mar 2018 14:46:29 +0100
From: Salvatore Mesoraca <s.mesoraca16@...il.com>
To: Stephan Mueller <smueller@...onox.de>
Cc: linux-kernel@...r.kernel.org,
Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-crypto@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>, Herbert Xu <herbert@...dor.apana.org.au>,
Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] crypto: ctr: avoid VLA use
2018-03-14 14:31 GMT+01:00 Stephan Mueller <smueller@...onox.de>:
> Am Mittwoch, 14. März 2018, 14:17:30 CET schrieb Salvatore Mesoraca:
>
> Hi Salvatore,
>
>> if (walk.nbytes) {
>> - crypto_ctr_crypt_final(&walk, child);
>> - err = blkcipher_walk_done(desc, &walk, 0);
>> + err = crypto_ctr_crypt_final(&walk, child);
>> + err = blkcipher_walk_done(desc, &walk, err);
>
> I guess you either want to handle the error from crypto_ctr_crypt_final or do
> an err |= blkcipher_walk_done.
I think that blkcipher_walk_done handles and returns the error for me.
Am I wrong?
Best regards,
Salvatore
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
