[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180310094327.685d181d@epycfail>
Date: Sat, 10 Mar 2018 09:43:27 +0100
From: Stefano Brivio <sbrivio@...hat.com>
To: Andreas Christoforou <andreaschristofo@...il.com>
Cc: keescook@...omium.org, kernel-hardening@...ts.openwall.com, Steffen
Klassert <steffen.klassert@...unet.com>, Herbert Xu
<herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>,
Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI
<yoshfuji@...ux-ipv6.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ipv6: xfrm6_state: remove VLA usage
On Sat, 10 Mar 2018 09:40:44 +0200
Andreas Christoforou <andreaschristofo@...il.com> wrote:
> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
> index b15075a..270a53a 100644
> --- a/net/ipv6/xfrm6_state.c
> +++ b/net/ipv6/xfrm6_state.c
> @@ -62,7 +62,7 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(void *p), int maxclass)
> {
> int i;
> int class[XFRM_MAX_DEPTH];
> - int count[maxclass];
> + int count[XFRM_MAX_DEPTH];
>
> memset(count, 0, sizeof(count));
Can you perhaps initialize 'count' instead of calling memset(), now?
--
Stefano
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
