[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180226010953.37z3sz3rwcnj426k@cisco>
Date: Sun, 25 Feb 2018 18:09:53 -0700
From: Tycho Andersen <tycho@...ho.ws>
To: "Tobin C. Harding" <me@...in.cc>
Cc: Kernel Hardening <kernel-hardening@...ts.openwall.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] leaking_addresses: add scan_once array
Hi Tobin,
On Mon, Feb 19, 2018 at 01:50:49PM +1100, Tobin C. Harding wrote:
> +sub already_scanned
> +{
> + my ($filename) = @_;
> + state %seen;
> +
> + foreach (@once_only) {
> + if (/^$filename$/) {
> + if ($seen{$_} == 1) {
This should be something like,
if (($seen{$_} //= 0) == 1) {
otherwise I get a bunch of uninitialized warnings,
Use of uninitialized value in pattern match (m//) at /usr/share/perl/5.26/Math/BigInt.pm line 1199.
Math::BigInt::bcmp(Math::BigInt=HASH(0x55dc2f7e4580), undef) called at /usr/share/perl/5.26/Math/BigInt.pm line 1257
Math::BigInt::beq(Math::BigInt=HASH(0x55dc2f7e4580), undef) called at /usr/share/perl/5.26/Math/BigInt.pm line 105
Math::BigInt::__ANON__(Math::BigInt=HASH(0x55dc2f7e4580), undef, 1) called at ./leaking_addresses.pl line 422
main::already_scanned("smaps") called at ./leaking_addresses.pl line 448
main::skip("/proc/1/smaps") called at ./leaking_addresses.pl line 509
main::walk("/proc", "/sys") called at ./leaking_addresses.pl line 159
Tycho
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
