[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1519008649-15782-5-git-send-email-me@tobin.cc>
Date: Mon, 19 Feb 2018 13:50:49 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Kernel Hardening <kernel-hardening@...ts.openwall.com>
Cc: "Tobin C. Harding" <me@...in.cc>,
Tycho Andersen <tycho@...ho.ws>,
LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 4/4] leaking_addresses: add scan_once array
There are files under /proc that have the same format for each PID, e.g
'smaps'. We need only scan these files a single time to verify that
they are not leaking addresses. This reduces the work the script must
do.
Add once_only array.
Signed-off-by: Tobin C. Harding <me@...in.cc>
---
scripts/leaking_addresses.pl | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index f52e91ef7d5c..ab4e70d9efde 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -69,6 +69,12 @@ my @skip_any = (
'fd',
'usbmon');
+# These files are the same format under each PID that they appear.
+# We need only pass them once.
+my @once_only = (
+ 'smaps',
+ 'mb_groups');
+
sub help
{
my ($exitcode) = @_;
@@ -401,6 +407,25 @@ sub parse_dmesg
close $cmd;
}
+sub already_scanned
+{
+ my ($filename) = @_;
+ state %seen;
+
+ foreach (@once_only) {
+ if (/^$filename$/) {
+ if ($seen{$_} == 1) {
+ return 1;
+ }
+ $seen{$_} = 1;
+
+ return 0;
+ }
+ }
+
+ return 0;
+}
+
# True if we should skip this path.
sub skip
{
@@ -415,6 +440,10 @@ sub skip
return 1 if (/^$filename$/);
}
+ if (already_scanned($filename)) {
+ return 1;
+ }
+
return 0;
}
--
2.7.4
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
