[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jJafqLN7b7kPYYsY8pP1tig8O8TsFkWvWeHG5mT3Gz1rw@mail.gmail.com>
Date: Wed, 24 May 2017 09:35:38 -0700
From: Kees Cook <keescook@...gle.com>
To: Rik van Riel <riel@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Daniel Micay <danielmicay@...il.com>,
"Ted Ts'o" <tytso@....edu>, "H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...capital.net>,
Ingo Molnar <mingo@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
Catalin Marinas <catalin.marinas@....com>, linux-sh <linux-sh@...r.kernel.org>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 5/5] sh64: ascii armor the sh64 boot init stack canary
On Wed, May 24, 2017 at 9:34 AM, Rik van Riel <riel@...hat.com> wrote:
> Use the ascii-armor canary to prevent unterminated C string overflows
> from being able to successfully overwrite the canary, even if they
> somehow obtain the canary value.
>
> Inspired by execshield ascii-armor and Daniel Micay's linux-hardened tree.
>
> Signed-off-by: Rik van Riel <riel@...hat.com>
Acked-by: Kees Cook <keescook@...omium.org>
-Kees
> ---
> arch/sh/include/asm/stackprotector.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/include/asm/stackprotector.h b/arch/sh/include/asm/stackprotector.h
> index d9df3a76847c..141515a43b78 100644
> --- a/arch/sh/include/asm/stackprotector.h
> +++ b/arch/sh/include/asm/stackprotector.h
> @@ -19,6 +19,7 @@ static __always_inline void boot_init_stack_canary(void)
> /* Try to get a semi random initial value. */
> get_random_bytes(&canary, sizeof(canary));
> canary ^= LINUX_VERSION_CODE;
> + canary &= CANARY_MASK;
>
> current->stack_canary = canary;
> __stack_chk_guard = current->stack_canary;
>
--
Kees Cook
Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
