Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1491371241.22446.11.camel@hellion.org.uk>
Date: Wed, 05 Apr 2017 06:47:21 +0100
From: Ian Campbell <ijc@...lion.org.uk>
To: Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, "Paul E. McKenney"
 <paulmck@...ux.vnet.ibm.com>, Kalle Valo <kvalo@...eaurora.org>, Andrew
 Morton <akpm@...ux-foundation.org>, Rik van Riel <riel@...hat.com>, Jakub
 Kicinski <jakub.kicinski@...ronome.com>, Viresh Kumar
 <viresh.kumar@...aro.org>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Geert Uytterhoeven
 <geert@...ux-m68k.org>, Olof Johansson <olof@...om.net>, Chris Wilson
 <chris@...is-wilson.co.uk>, George Spelvin <linux@...encehorizons.net>,
 Thomas Gleixner <tglx@...utronix.de>, Josh Poimboeuf <jpoimboe@...hat.com>,
 David Windsor <dwindsor@...il.com>, linux-kernel@...r.kernel.org, 
 kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v2 1/7] bug: Clarify help text for
 BUG_ON_DATA_CORRUPTION

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 77fadface4f9..5ac4d1148385 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1998,9 +1998,12 @@ config BUG_ON_DATA_CORRUPTION
> >  	bool "Trigger a BUG when data corruption is detected"
> >  	select DEBUG_LIST
> >  	help
> > -	  Select this option if the kernel should BUG when it encounters
> > -	  data corruption in kernel memory structures when they get checked
> > -	  for validity.
> > +	  This option enables several inexpensive data corruption checks.
> > +	  Most of these checks normally just WARN and try to further avoid
> +	  the corruption. Selecting this option upgrades these to BUGs so

First it says it enables some checks, but here it says it upgrades them
to BUGs which seems inconsistent.

> +	  that the offending process is killed. Additionally, the system
> +	  owner can furhter configure the system for immediate reboots

                   "further"

> +	  (via panic_on_oops sysctl) or crash dumps.
>  
> >  	  If unsure, say N.
>  

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.