[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170213103815.GA5131@infradead.org>
Date: Mon, 13 Feb 2017 02:38:15 -0800
From: Christoph Hellwig <hch@...radead.org>
To: David Windsor <dwindsor@...il.com>
Cc: Jeff Layton <jlayton@...chiereds.net>, linux-nfs@...r.kernel.org,
netdev@...r.kernel.org, kernel-hardening@...ts.openwall.com,
Bruce Fields <bfields@...ldses.org>,
Kees Cook <keescook@...omium.org>,
"Reshetova, Elena" <elena.reshetova@...el.com>
Subject: Re: [RFC][PATCH] nfsd: add +1 to reference counting scheme for
struct nfsd4_session
On Sat, Feb 11, 2017 at 09:01:15AM -0500, David Windsor wrote:
> I'm not sure there's another way to accomplish what we need
> (initializing struct nfsd4_session objects with refcount=1) without
> also modifying the freeable reference state. After migrating to the
> refcount_t API, if we leave init_session() as is, the first call to
> nfsd4_get_session_locked() will fail:
Which is a pretty clear indicator that this code should simply not
migrate to the recount_t API. Why was it even considered if the
conversion is obviously broken?
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
