[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161128091830.GB23034@linaro.org>
Date: Mon, 28 Nov 2016 18:18:31 +0900
From: AKASHI Takahiro <takahiro.akashi@...aro.org>
To: Andreas Ziegler <andreas.ziegler@....de>,
Rusty Russell <rusty@...tcorp.com.au>, Jessica Yu <jeyu@...hat.com>
Cc: Kees Cook <keescook@...omium.org>, kernel-hardening@...ts.openwall.com,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to
module mappings
On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
> Hi Akashi,
>
> your patch "module: extend 'rodata=off' boot cmdline parameter to module
> mappings" showed up in linux-next today, and I noticed a small error in it.
>
> The first modified #ifdef is fine, the second one, however, has a spelling
> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).
Thank you for pointing this out.
(I didn't notice it because DEBUG_RODATA is always on on arm64.)
Rusty, Jessica, should I submit v4 to correct it?
-Takahiro AKASHI
> I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which is essentialy diffing the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
>
> Best regards,
>
> Andreas
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
