[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160816175726.31b55326@gandalf.local.home>
Date: Tue, 16 Aug 2016 17:57:26 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Kees Cook <keescook@...omium.org>
Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>, Stephen Boyd
<sboyd@...eaurora.org>, Daniel Micay <danielmicay@...il.com>, Arnd Bergmann
<arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Josh
Triplett <josh@...htriplett.org>, Mathieu Desnoyers
<mathieu.desnoyers@...icios.com>, Lai Jiangshan <jiangshanlai@...il.com>,
Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Tejun Heo <tj@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, "Aneesh
Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, "Kirill A. Shutemov"
<kirill.shutemov@...ux.intel.com>, Andrew Morton
<akpm@...ux-foundation.org>, Dan Williams <dan.j.williams@...el.com>, Jan
Kara <jack@...e.cz>, Josef Bacik <jbacik@...com>, Thomas Gleixner
<tglx@...utronix.de>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Nikolay
Aleksandrov <nikolay@...ulusnetworks.com>, Dmitry Vyukov
<dvyukov@...gle.com>, LKML <linux-kernel@...r.kernel.org>,
"kernel-hardening@...ts.openwall.com"
<kernel-hardening@...ts.openwall.com>, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 4/5] bug: Provide toggle for BUG on data corruption
On Tue, 16 Aug 2016 17:53:54 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> WARN(1, "list_del corruption. next->prev should be %p, but was %p\n",
> entry, next->prev);
> BUG_ON(CORRUPTED_DATA_STRUCTURE);
>
> Will always warn (as stated by "1") and and the BUG_ON() will bug if
> CORRUPTED_DATA_STRUCTURE is set. Although, I don't like that name. Can
> we have a:
>
> BUG_ON(BUG_ON_CORRUPTED_DATA_STRUCTURES);
>
> Or maybe have that as a macro:
>
> #ifdef CONFIG_BUG_ON_CORRUPTION
> # define BUG_ON_CORRUPTED_DATA_STRUCTURE() BUG_ON(1)
> #else
> # define BUG_ON_CORRUPTED_DATA_STRUCTURE() do {} while (0)
> #endif
>
> Then we can have:
>
> WARN(1, "list_del corruption. next->prev should be %p, but was %p\n",
> entry, next->prev);
> BUG_ON_CORRUPTED_DATA_STRUCTURE();
>
> ??
>
Hmm, maybe better yet, just have it called "CORRUPTED_DATA_STRUCTURE()"
because it wont bug if the config is not set, and having "BUG_ON" in
the name, it might be somewhat confusing.
-- Steve
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
