Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20160502195617.9b2b7e07ced214a8f2136364@gmail.com>
Date: Mon, 2 May 2016 19:56:17 +0200
From: Emese Revfy <re.emese@...il.com>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>, PaX Team
 <pageexec@...email.hu>, Brad Spengler <spender@...ecurity.net>,
 kernel-hardening@...ts.openwall.com, Michal Marek <mmarek@...e.com>, Kees
 Cook <keescook@...omium.org>, Rasmus Villemoes <linux@...musvillemoes.dk>,
 Fengguang Wu <fengguang.wu@...el.com>, Dmitry Vyukov <dvyukov@...gle.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, David Brown
 <david.brown@...aro.org>
Subject: Re: [PATCH v7 1/6] Shared library support

On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> In the first place,
> I am wondering if we need to revive this documentation.
> What this commit is only interested in *.so generation,
> not host program support.

I agree that we don't need this documentation. I'll remove it.
  
> > @@ -124,5 +158,39 @@ quiet_cmd_host-cxxobjs     = HOSTCXX $@
> >  $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
> >         $(call if_changed_dep,host-cxxobjs)
> >
> > +# Compile .c file, create position independent .o file
> > +# host-cshobjs -> .o
> > +quiet_cmd_host-cshobjs = HOSTCC  -fPIC $@
> > +      cmd_host-cshobjs = $(HOSTCC) $(hostc_flags) -fPIC -c -o $@ $<
> > +$(host-cshobjs): $(obj)/%.o: $(src)/%.c FORCE
> > +       $(call if_changed_dep,host-cshobjs)
> > +
> > +# Compile .c file, create position independent .o file
> 
> 
> Please explain why c++ compiler should be used to compile .c files.
> 
> This is not clear, so worth commenting.

Where do you think that the C++ compiler is used above? I think HOSTCC can only be C compiler.

-- 
Emese

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.