[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120725121644.GA6584@redhat.com>
Date: Wed, 25 Jul 2012 14:16:44 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Djalal Harouni <tixxdz@...ndz.org>
Cc: linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
Al Viro <viro@...iv.linux.org.uk>,
Andrew Morton <akpm@...ux-foundation.org>,
Vasiliy Kulikov <segoon@...nwall.com>,
WANG Cong <xiyou.wangcong@...il.com>,
Solar Designer <solar@...nwall.com>, Kees Cook <keescook@...omium.org>,
David Rientjes <rientjes@...gle.com>,
Brad Spengler <spender@...ecurity.net>
Subject: Re: [PATCH v2 2/2] proc: do not allow negative offsets on
/proc/<pid>/environ
On 07/24, Djalal Harouni wrote:
>
> static int mem_open(struct inode *inode, struct file *file)
> {
> - return __mem_open(inode, file, PTRACE_MODE_ATTACH);
> + int ret = __mem_open(inode, file, PTRACE_MODE_ATTACH);
> +
> + /* OK to pass negative loff_t, we can catch out-of-range */
> + file->f_mode |= FMODE_UNSIGNED_OFFSET;
> +
> + return ret;
> }
It could be even simpler, I meant
file->f_mode |= FMODE_UNSIGNED_OFFSET;
return __mem_open(inode, file, PTRACE_MODE_ATTACH);
Never mind, this is very minor and the patch is already in -mm.
Oleg.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
