[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jJTJ2uz-GGCXhHtUnGiZy=ChXVWYey8d2XTa4gZjJ7w2w@mail.gmail.com>
Date: Tue, 24 Jul 2012 10:41:06 -0700
From: Kees Cook <keescook@...omium.org>
To: Djalal Harouni <tixxdz@...ndz.org>
Cc: linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
Al Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>,
Vasiliy Kulikov <segoon@...nwall.com>, WANG Cong <xiyou.wangcong@...il.com>,
Oleg Nesterov <oleg@...hat.com>, Solar Designer <solar@...nwall.com>,
David Rientjes <rientjes@...gle.com>, Brad Spengler <spender@...ecurity.net>
Subject: Re: [PATCH v2 0/2] proc: /proc/<pid>/environ offset fixes
Hi,
On Tue, Jul 24, 2012 at 8:29 AM, Djalal Harouni <tixxdz@...ndz.org> wrote:
> This is the V2 to correctly check offsets on /proc/<pid>/environ before
> reading. This was previously discussed here:
> http://lkml.org/lkml/2012/7/22/79
>
> Due to incorrect offset checks, currently one can read from aribtrary
> addresses on /proc/<pid>/environ, not only the environment address range
> as shown here (the same thread):
> http://lkml.org/lkml/2012/7/22/163
>
> The bug is in environ_read().
> [...]
> Djalal Harouni (2):
> proc: environ_read() make sure offset points to environment address range
> proc: do not allow negative offsets on /proc/<pid>/environ
>
> fs/proc/base.c | 22 +++++++++++++---------
> 1 files changed, 13 insertions(+), 9 deletions(-)
This looks good, thanks!
Acked-by: Kees Cook <keescook@...omium.org>
-Kees
--
Kees Cook
Chrome OS Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
