[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110914191417.GA15936@albatros>
Date: Wed, 14 Sep 2011 23:14:17 +0400
From: Vasiliy Kulikov <segoon@...nwall.com>
To: Dave Hansen <dave@...ux.vnet.ibm.com>
Cc: kernel-hardening@...ts.openwall.com,
Andrew Morton <akpm@...ux-foundation.org>,
Cyrill Gorcunov <gorcunov@...il.com>,
Al Viro <viro@...iv.linux.org.uk>,
Christoph Lameter <cl@...ux-foundation.org>,
Pekka Enberg <penberg@...nel.org>, Matt Mackall <mpm@...enic.com>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [RFC PATCH 2/2] mm: restrict access to /proc/slabinfo
On Wed, Sep 14, 2011 at 11:41 -0700, Dave Hansen wrote:
> On Sat, 2011-09-10 at 20:41 +0400, Vasiliy Kulikov wrote:
> > @@ -4584,7 +4584,8 @@ static const struct file_operations proc_slabstats_operations = {
> >
> > static int __init slab_proc_init(void)
> > {
> > - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> > + proc_create("slabinfo", S_IWUSR | S_IRUSR, NULL,
> > + &proc_slabinfo_operations);
> > #ifdef CONFIG_DEBUG_SLAB_LEAK
> > proc_create("slab_allocators", 0, NULL, &proc_sla
>
> If you respin this, please don't muck with the whitespace.
OK, I was just removing checkpatch warnings.
> Otherwise,
> I'm fine with this. Distros are already starting to do this anyway in
> userspace.
>
> Reviewed-by: Dave Hansen <dave@...ux.vnet.ibm.com>
Thank you!
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
