[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150914174047.GA10906@openwall.com>
Date: Mon, 14 Sep 2015 20:40:47 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: SHA-1 H()
On Mon, Sep 14, 2015 at 07:03:57PM +0200, magnum wrote:
> That failure was unrelated. The PR is merged now, good stuff!
Yeah, looks good to me.
A minor detail, in this piece:
#if __AVX512F__
#undef vcmov
#define vcmov(x, y, z) vternarylogic(x, y, z, 0xE4)
#define vternarylogic _mm512_ternarylogic_epi32
#endif
I think we need to add:
#undef VCMOV_EMULATED
right after the "#undef vcmov". Since we have a one instruction
implementation, it is as good as native, non-emulated vcmov.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
