john-dev - Re: testing every index (Re: more robustness)

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABtNtWGAN-jZY7qoaZ4B9xgyiWq5xeF-dqqbPQm2yUKdYY4ABQ@mail.gmail.com>
Date: Sun, 23 Aug 2015 21:28:45 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: testing every index (Re: more robustness)

Hi Alexander,

On Sun, Aug 23, 2015 at 2:22 AM, Solar Designer <solar@...nwall.com> wrote:
>
> If you re-order the test vectors, e.g. swap 5 and 7, will this hide this
> unusual property from your current test?  If so, maybe do that (even
> though it's very nice your test let us know of this property now).

Yes. After swap the 5th and 7th, the --test-full could not detect this problem.
Should we commit this change ?

diff --git a/src/AFS_fmt.c b/src/AFS_fmt.c
index 01bd3ad..3f2507e 100644
--- a/src/AFS_fmt.c
+++ b/src/AFS_fmt.c
@@ -33,9 +33,9 @@ static struct fmt_tests tests[] = {
        {"$K4$d9e985b36268f168,01234567", "U*U***U"},
        {"$K4$b9615786dfb53297,longcellname", "longpassword"},
        {"$K4$a8dc8aeaa2c48a97,", ""},
-       {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
        {"$K4$e3e59de6f1d5eaf4,cell", "password355"},
        {"$K4$b02cc24aefbc865b,", "thisisaverylongpassword"},
+       {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
        {NULL}
 };


Thanks,

Kai

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.