Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <930d469b15c9b021a90353bb1212151a@smtp.hushmail.com>
Date: Wed, 06 May 2015 21:18:53 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: John core: --format=crypt rejecting descrypt hashes
 when it first found some bfegg hashes

On 2015-05-06 16:29, Solar Designer wrote:
> "Detect descrypt with valid vs. invalid salts as separate id's for our
> heuristics on supported hash types.  According to Frank Dittrich, recent
> Fedora's crypt(3) no longer supports invalid descrypt salts even when it
> does support descrypt."
>
> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/c3_fmt.c.diff?r1=1.29;r2=1.30
>
> Jim's patch in jumbo should be reverted when merging this.

Just FYI, I got this when regression testing the merge (though the below 
is from pristine core)

c3_fmt.c: In function 'valid':
c3_fmt.c:100:19: warning: 'count_base64_2' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
   if (length >= 13 &&
                    ^

I had no time to review it yet, might be a false positive. This was gcc 
4.9.2.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.