john-dev - Re: Regular Expression mode for JtR

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d62c8851a89c9232984e36bf7944117@smtp.hushmail.com>
Date: Tue, 2 Jul 2013 10:00:40 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Regular Expression mode for JtR

On 2 Jul, 2013, at 9:46 , magnum <john.magnum@...hmail.com> wrote:
> On 27 Jun, 2013, at 22:45 , Jan Starke <jan.starke@...ofbed.org> wrote:
>> Attached you find my first attempt, which seems to be working.
> 
> I think you should rebase your patch on the bleeding-jumbo branch of GitHub

BTW by "GitHub" I mean https://github.com/magnumripper/JohnTheRipper (but be sure to check out branch "bleeding-jumbo" as it's not the default). Or use a snapshot tarball from:
https://github.com/magnumripper/JohnTheRipper/tarball/bleeding-jumbo


> I did test your current C++ version rebased on bleeding-jumbo, after fixing some minor issues. I enclose the resulting patch (it includes your patch and applies on top of current bleeding).

There was a slight bug in my patch (too) although it worked fine here:

diff --git a/src/Makefile b/src/Makefile
index de38477..aeb14ec 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -2312,7 +2312,7 @@ john.o: john.c fmt_externs.h fmt_registers.h
        $(CC) $(CFLAGS) $(OPT_NORMAL) $< -o $@
 
 .cpp.o:
-       $(CPP) $(CFLAGS) $(OPT_NORMAL) -std=c++0x $*.cpp
+       $(CXX) $(CFLAGS) $(OPT_NORMAL) -std=c++0x $*.cpp
 
 .S.o:
        $(AS) $(ASFLAGS) $*.S



magnum

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.