Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50F33FC2.9060509@gmail.com>
Date: Sun, 13 Jan 2013 21:14:10 -0200
From: Claudio André <claudioandre.br@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Changes to common-opencl.c

Em 13-01-2013 18:36, magnum escreveu:
> Device 1: Tahiti (AMD Radeon HD 7900 Series)

Commited.

> For parsing, try to follow how --groups are parsed in options.c and getopt.[ch]. It seems the provided functions can do most things we need. I haven't looked at it now but I'd expect some "documentation" within getopt.h.

I was thinking about creating a function to do something like snipped 
below. But, seems you meant something else using 'options_main', 
list_init(), etc. I would prefer to avoid messing with core this way. 
Could you please clarify?
---

p = options.gpu_devices;

for(p = s; *p != '\0'; p++)
   {
     p = strchr(p, ',');
     ...

BTW: having --device and --devices will disable -de:1 option. Is this ok 
for everybody?

Claudio


Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.