|
Message-ID: <20130106170045.BOGXB.721937.imail@eastrmwml207> Date: Sun, 6 Jan 2013 17:00:45 -0500 From: <jfoug@....net> To: john-dev@...ts.openwall.com Subject: Re: Mask mode (was Password Generation on GPU) Actually, that while should also be changed to an if: - while (maskset_pos[last_mask_index] == maskset_num[last_mask_index]) { + if (maskset_pos[last_mask_index] == maskset_num[last_mask_index]) { ---- jfoug@....net wrote: > Not the greatest fix, but until someone has more time to look into it. > > while (maskset_pos[last_mask_index] == maskset_num[last_mask_index]) { > + if (last_mask_index==first_mask_index) return; > maskset_pos[last_mask_index] = 0; > > > ---- magnum <john.magnum@...hmail.com> wrote: > > On 6 Jan, 2013, at 17:05 , jfoug@....net wrote: > > > Here is a replacement for the mask_generate() function which works. This is likely far from optimal, but should properly iterate the entire mask, from right to left. > > > > > > This is not a patch, it is a replacement for the existing function. I simply renamed the original function to mask_generate_bak(), and added this new one, which was derived from the original function. > > > > Your function is buggy too... Try giving a single mask, like --mask=?u or --mask=?lol > > > > magnum >
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.