|
Message-ID: <50596CF9.6090006@mccme.ru> Date: Wed, 19 Sep 2012 10:58:01 +0400 From: Alexander Cherepanov <cherepan@...me.ru> To: john-dev@...ts.openwall.com Subject: Re: Static analysis of John using Coverity On 2012-09-19 01:15, Alexander Cherepanov wrote: > On 2012-09-17 01:23, Alexander Cherepanov wrote: >> And I suspect that every format with trivial valid() -- there are >> ~40-50 of them -- have buffer overflows in get_salt and/or similar >> functions. You don't need a code analyzer to find them. > > To have something for a start here are crashers for 36 formats: [skip] > They crash fresh magnum-john built linux-x86-64i. Didn't take time to ^ for ^ I > really trigger buffer overflows in all these cases. And I didn't look at > cuda and opencl formats at all. If forgot to include several cases. john crashes on this: $DIGEST-MD5$xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx$$$$$$auth$ john overflows dynamic buffer, supposedly overwrites test vectors and then fails self-test on this: $response$$$xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx$$$$$$ john crashes while reading file consisting of two lines: $B$$0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 $B$$0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 john --format=dynamic_21 crashes on this: 00000000000000000000000000000000 (it doesn't crash without --format). -- Alexander Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.