[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANO7a6z5Wt9_cMNG6NQaHcknkesdeG1v2-LNCjYR1eo35bRWCw@mail.gmail.com>
Date: Sun, 8 Jul 2012 19:02:12 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: [PATCH] integrate psk-crack (from ike-scan) into john.
On Sun, Jul 8, 2012 at 3:31 PM, Solar Designer <solar@...nwall.com> wrote:
> Dhiru -
>
> On Sat, Jul 07, 2012 at 06:49:46PM +0530, Dhiru Kholia wrote:
>> The attached patch (alpha quality) integrates psk-crack (from
>> ike-scan) into john.
>
> I think hstr_i() and hex2data() should be declared static. In fact, I
> dislike having function bodies in the .h file. While the Linux kernel
> has some inline functions in .h files, it does so for specific good
> reasons, which don't apply here.
Fixed the static part.
> Also, please try benchmarking this for non-OpenMP vs. OpenMP at 1 thread.
> I suspect that the latter might be faster, which will suggest that you
> have the same non-OpenMP performance problem that you did in the SIP
> format. Please address it if so.
$ ../run/john -format:ike -t
Benchmarking: IKE PSK HMAC-MD5 / HMAC-SHA1 [32/64]... DONE
Raw: 435759 c/s real, 435759 c/s virtual
Seems to be fine. No problems.
List,
Any ideas what magnum is up to? Haven't heard from him.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
