john-dev - Re: [PATCH] integrate psk-crack (from ike-scan) into john.

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120708100127.GF29763@openwall.com>
Date: Sun, 8 Jul 2012 14:01:27 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: [PATCH] integrate psk-crack (from ike-scan) into john.

Dhiru -

On Sat, Jul 07, 2012 at 06:49:46PM +0530, Dhiru Kholia wrote:
> The attached patch (alpha quality) integrates psk-crack (from
> ike-scan) into john.

I think hstr_i() and hex2data() should be declared static.  In fact, I
dislike having function bodies in the .h file.  While the Linux kernel
has some inline functions in .h files, it does so for specific good
reasons, which don't apply here.

Also, please try benchmarking this for non-OpenMP vs. OpenMP at 1 thread.
I suspect that the latter might be faster, which will suggest that you
have the same non-OpenMP performance problem that you did in the SIP
format.  Please address it if so.

Thanks,

Alexander

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.