[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mpro.m6fgbi03xhvmo00sk.taviso@cmpxchg8b.com>
Date: Sat, 30 Jun 2012 13:09:18 +0200
From: Tavis Ormandy <taviso@...xchg8b.com>
To: john-dev@...ts.openwall.com
Subject: Re: Re: asan report
magnum <john.magnum@...hmail.com> wrote:
> On 2012-06-30 12:42, Tavis Ormandy wrote:
> > It is complaining that I assume the key passed to set_key can be read
> > with one MOVDQU, I documented this in the comments. I would prefer not
> > to change this, because it is a very hot path.
>
> As you can see discussed, this will be taken care of in core. This does
> not have to be aligned, right?
Right, doesn't have any alignment requirements.
> > In fact, I was going to suggest adding a flag that guarantees it will be
> > 16-byte aligned so I can use MOVDQA.
>
> I've had such thoughts too. But I'm not sure how we'd handle wordlist
> buffer mode (which is a huge speedup). We'll need to think it over.
>
OK, sounds good to me.
Tavis.
--
-------------------------------------
taviso@...xchg8b.com | pgp encrypted mail preferred
-------------------------------------------------------
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
