[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120629012916.GA26993@openwall.com>
Date: Fri, 29 Jun 2012 05:29:16 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: office2john.c command-line
On Fri, Jun 29, 2012 at 12:50:35AM +0400, Solar Designer wrote:
> if (argc < 2) {
> fprintf(stderr, "Usage: %s <Office 2007 / 2010 encrypted files\n", argv[0]);
>
> The "< 2" check and the word "files" suggests that multiple files may be
> specified. However, the code actually only processes argv[1].
>
> Also, what does "<" in the Usage line mean? Maybe there was meant to be
> a closing ">" as well? Either way, this is confusing since these are
> also shell meta-characters for input/output redirection.
I've patched this in my tree now.
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
