|
|
Message-ID: <20120628205035.GB25173@openwall.com>
Date: Fri, 29 Jun 2012 00:50:35 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: office2john.c command-line
Dhiru -
The usage output is:
if (argc < 2) {
fprintf(stderr, "Usage: %s <Office 2007 / 2010 encrypted files\n", argv[0]);
The "< 2" check and the word "files" suggests that multiple files may be
specified. However, the code actually only processes argv[1].
Also, what does "<" in the Usage line mean? Maybe there was meant to be
a closing ">" as well? Either way, this is confusing since these are
also shell meta-characters for input/output redirection.
I think we need to fix this.
Thanks,
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.