Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a22eb4b8254d63709756c77b416787c7@smtp.hushmail.com>
Date: Thu, 28 Jun 2012 11:14:29 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: linux-x86-clang build broken: UTF-8 byte order mark
 detected in 'keepass2john.c', but encoding is not supported

On 2012-06-28 11:08, Frank Dittrich wrote:
> On 06/28/2012 10:49 AM, magnum wrote:
>> On 2012-06-28 10:46, Frank Dittrich wrote:
>>> $ file keepass2john.c
>>> keepass2john.c: UTF-8 Unicode (with BOM) English text
>>
>> UTF-8 BOM is the worst idea ever. I will fix.
> 
> The funny thing is that with git diff I saw the removed BOM, but in the
> patch created with git format-patch  and on github you don't see any
> differences.

It's the same when you fix legacy line endings. I'm not sure why it even
works, but it does.

> Isn't there some git magic which prevents accidentally committing such
> files, or some pre-commit hook to remove BOMs (and trailing spaces) from
> .c/.h files?

I'm already googling that :)

magnum


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.