Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP15595AC06E3C41FBE42654FDE60@phx.gbl>
Date: Thu, 28 Jun 2012 11:08:37 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: linux-x86-clang build broken: UTF-8 byte order mark
 detected in 'keepass2john.c', but encoding is not supported

On 06/28/2012 10:49 AM, magnum wrote:
> On 2012-06-28 10:46, Frank Dittrich wrote:
>> $ file keepass2john.c
>> keepass2john.c: UTF-8 Unicode (with BOM) English text
> 
> UTF-8 BOM is the worst idea ever. I will fix.

The funny thing is that with git diff I saw the removed BOM, but in the
patch created with git format-patch  and on github you don't see any
differences.

Isn't there some git magic which prevents accidentally committing such
files, or some pre-commit hook to remove BOMs (and trailing spaces) from
.c/.h files?

Frank

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.