Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120623014106.GA31525@openwall.com>
Date: Sat, 23 Jun 2012 05:41:06 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Oracle Bitslice conversion completed

Hi Piyush,

On Sat, Jun 23, 2012 at 06:47:57AM +0530, Piyush Mittal wrote:
> I have completed Oracle Bit Slice conversion. It's running  correctly using
> linux-x86-64avx mode on my machine.

This is very nice.  Thank you!

> Sorry I was not able to attach the patch because of size limit but here is
> its external link:
> 
> https://www.dropbox.com/s/sf96z1fq8vd1gt8/oracle_bitslice.patch

As discussed off-list, you were not able to attach the patch not because
of the size limit, but because you included lots of irrelevant stuff in
it.  The size limit has worked just fine, preventing you from posting a
non-clean patch. ;-)  This is what we have the limit for. ;-)

All those tilde-suffixed files (backup copies created by a text editor)
should not be included in the patch.  One way to exclude them is to use
the "-x *~" option to diff.

Please clean up the patch and post it.

$ diffstat oracle_bitslice.patch 
 DES_bs.c           |   23 
 DES_bs.c~          |  498 +++++++++++++++
 DES_bs.h           |   10 
 DES_bs.h~          |  195 ++++++
 DES_bs_b.c         |  161 ++++
 DES_bs_b.c~        | 1722 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 DES_fmt.c~         |  416 ++++++++++++
 LM_fmt.c~          |  468 ++++++++++++++
 Makefile~          | 1375 ++++++++++++++++++++++++++++++++++++++++++
 formats.c~         |  204 ++++++
 oracle_fmt_plug.c  |  534 ++++++++--------
 oracle_fmt_plug.c~ |  404 ++++++++++++
 unicode.c~         | 1306 ++++++++++++++++++++++++++++++++++++++++
 13 files changed, 7063 insertions(+), 253 deletions(-)

Thanks again,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.