[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP140B80D355D10EF7371A1CEFDE30@phx.gbl>
Date: Sat, 23 Jun 2012 19:46:55 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: segfault with ./john --test --format=md5ns caused
by commit aab646b42afe93ca909ba1a99bc0e2a1b027a79d
On 06/23/2012 06:59 PM, Solar Designer wrote:
> Frank -
>
> On Sat, Jun 23, 2012 at 12:16:58PM +0200, Frank Dittrich wrote:
>> I could be wrong, but the commit that looks like it could have caused
>> this regression is
>> aab646b42afe93ca909ba1a99bc0e2a1b027a79d
>> Use first two salts when benchmarking instead of top one.
>
> I think the attached patch should fix this. Please test.
>
> The shadowing of "current" is not great, but a nearby change in jumbo
> already does the same thing anyway.
I get these warnings when building john:
john.c: In function ‘john_init’:
john.c:779:22: warning: unused variable ‘current’ [-Wunused-variable]
john.c:773:7: warning: variable ‘i’ set but not used
[-Wunused-but-set-variable]
But the segfault disappeared.
Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
