[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120617163750.GA9350@openwall.com>
Date: Sun, 17 Jun 2012 20:37:50 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: [patch] optional new raw sha1 implemetation
On Sun, Jun 17, 2012 at 06:14:09PM +0200, Tavis Ormandy wrote:
> On Sun, Jun 17, 2012 at 07:27:53PM +0400, Solar Designer wrote:
> > The SSE4.1 trick could be handy for vectorizing DES_bs_cmp_all(),
> > although it is non-obvious whether that would provide any speedup over
> > the current non-vectorized version even with that trick. Thank you for
> > bringing it to us for possible reuse. ;-)
>
> It performs pretty well on intel, I don't know if it will be worth it
> for AMD hardware.
Yes, it appears to help at least on FX-8120 as well (in your code).
The uncertainty I referred to above has to do with DES_bs_cmp_all()
specifics.
> > The file taviso_fmt.c should probably be renamed. I don't mind it
> > including "taviso" if you like, but it should also include "sha1".
>
> I don't mind, it was just what I called my working copy. how about
> sha1_ng_fmt? Whatever you prefer is fine.
rawSHA1_ng_fmt.c maybe. (We have rawSHA1_fmt_plug.c.)
> > The format label rawsha1_sse4 should probably be renamed because there's
> > no hard dependency on SSE4.1 anymore.
>
> Sure, any suggestions?
raw-sha1-ng (we have raw-sha1 for the old one).
Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
