[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BLU0-SMTP74A70CAB1CDE4BDE5858B2FDF70@phx.gbl>
Date: Mon, 11 Jun 2012 12:45:10 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Patch: allow --markov=SECTION in addition to --markov[=[MIN_LEVEL-]LEVEL[:START[:END[:[MIN_LENGHT-]LENGTH]]]]
On 06/09/2012 09:18 PM, Frank Dittrich wrote:
> I verified that the old logic still works, and that I can interrupt and
> restore a session using --markov=section
In addition to the segfault when using --markov I also found errors when
reading MkvStart ans MkvEnd.
In preparation of adding --markov=SECTION support, I'd like to get two
other patches into magnum's repository on github:
1. Move markov option handling to mkv.c (do_markov_crack)
Doing all parameter validation in one place (mkv.c, do_mkv_crack())
instead of in two places (options.c in opt_init() and in mkv.c in
do_mkv_crack())
---
src/john.c | 2 +-
src/mkv.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++-
src/mkv.h | 2 +-
src/options.c | 65
---------------------------------------------------------
src/options.h | 6 -----
5 files changed, 61 insertions(+), 74 deletions(-)
2. use [Markov:Default] instead of [Options:Markov] for --markov
doc/MARKOV | 22 +++++++++++++++++++++-
run/john.conf | 17 ++++++++++-------
src/mkv.c | 8 +++++---
src/params.h | 2 +-
4 files changed, 37 insertions(+), 12 deletions(-)
I'd like to get these changes in prior to the next jumbo release,
even if I don't manage the --markov=SECTION stuff in time.
The reason is, I'd like to avoid another incompatible change.
Now Markov default values are unter [Options], next jumbo moves them to
[Options:Markov], --markov=SECTION support moves them to [Markov:Default].
Should I resend those patches together with the third patch which will
introduce --markov=SECTION support?
The third patch will not yet support --markov=SECTION:LEVEL...
This will be a 4th patch.
Frank
View attachment "0001-Move-markov-option-handling-to-mkv.c-do_markov_crack.patch" of type "text/x-patch" (6767 bytes)
View attachment "0002-use-Markov-Default-instead-of-Options-Markov-for-mar.patch" of type "text/x-patch" (4677 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
