[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f6c057605b956f47546a7f59290afe88@smtp.hushmail.com>
Date: Sun, 27 May 2012 23:08:53 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: mschapv2 conversion
OK, that seems to work. But as long as it breaks the normal builds, I
can't commit it. Could you try to get it work for at least linux-x86-sse2?
This might be just an arch.h issue though. Solar?
Speeds before:
Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE
Many salts: 2304K c/s real, 2317K c/s virtual
Only one salt: 1638K c/s real, 1638K c/s virtual
After:
Benchmarking: MSCHAPv2 C/R MD4 DES [mschapv2]... DONE
Many salts: 4861K c/s real, 4861K c/s virtual
Only one salt: 2466K c/s real, 2466K c/s virtual
I think you should change ALGORITHM_NAME to reflect that we are using
BS. Maybe you could just use DES_BS_ALGORITHM_NAME?
BTW, I get these warnings:
MSCHAPv2_fmt_plug.c: In function ‘generate_output’:
MSCHAPv2_fmt_plug.c:269:10: warning: pointer targets in assignment
differ in signedness [-Wpointer-sign]
MSCHAPv2_fmt_plug.c: In function ‘mschapv2_set_salt’:
MSCHAPv2_fmt_plug.c:425:15: warning: unused variable ‘temp’
[-Wunused-variable]
A more serious problem is that you break OMP builds even for generic:
DES_bs_b.c: In function ‘DES_bs_crypt_one’:
DES_bs_b.c:1571:1: error: ‘t’ undeclared (first use in this function)
DES_bs_b.c:1571:1: note: each undeclared identifier is reported only
once for each function it appears in
DES_bs_b.c:1571:1: error: ‘n’ undeclared (first use in this function)
DES_bs_b.c:1576:2: error: too few arguments to function
‘DES_bs_finalize_keys’
DES_bs_b.c:998:26: note: declared here
make[1]: *** [DES_bs_b.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [generic.h] Error 1
magnum
On 05/27/2012 10:35 PM, deepika dutta wrote:
> I am building it using make generic. BTW I am working on 32 bit Scientific Linux-6.2 system. Cheers,
> Deepika
>
>
> ________________________________
> From: magnum <john.magnum@...hmail.com>
> To: john-dev@...ts.openwall.com
> Sent: Monday, May 28, 2012 1:25 AM
> Subject: Re: [john-dev] mschapv2 conversion
>
> On 05/27/2012 03:41 PM, deepika dutta wrote:
>> I have attached freshly created patch and tested it on my system. I was able to make it work. This is how I created and tested patch.
>>
>> Original jtr directory: john-1.7.9-jumbo-5.orig/
>> Modified jtr directory: john-1.7.9-jumbo-5/
>>
>> john-1.7.9-jumbo5.diff patch creation:
>> TZ=UTC diff -urpN john-1.7.9-jumbo-5.orig/ john-1.7.9-jumbo-5 > john-1.7.9-jumbo5.diff
>>
>> Testing the patch
>> cd john-1.7.9-jumbo-5.orig/
>> patch -p1 -Z < ../john-1.7.9-jumbo5.diff
>
> This patch applied fine but I still can't build it (see below). I also
> tried a 32-bit build to no avail. What system did you test this on?
>
> magnum
>
>
> DES_bs_b.c: In function ‘DES_bs_crypt_one’:
> DES_bs_b.c:1576:2: warning: implicit declaration of function
> ‘DES_bs_finalize_keys’ [-Wimplicit-function-declaration]
> DES_bs_b.c:1586:19: error: incompatible types when assigning to type
> ‘DES_bs_vector’ from type ‘long int *’
> DES_bs_b.c:1589:3: warning: implicit declaration of function
> ‘for_each_depth’ [-Wimplicit-function-declaration]
> DES_bs_b.c:1590:3: error: expected ‘;’ before ‘s1’
> DES_bs_b.c:1594:3: error: expected ‘;’ before ‘s2’
> DES_bs_b.c:1598:3: error: expected ‘;’ before ‘s3’
> DES_bs_b.c:1602:3: error: expected ‘;’ before ‘s4’
> DES_bs_b.c:1606:3: error: expected ‘;’ before ‘s5’
> DES_bs_b.c:1610:3: error: expected ‘;’ before ‘s6’
> DES_bs_b.c:1614:3: error: expected ‘;’ before ‘s7’
> DES_bs_b.c:1618:3: error: expected ‘;’ before ‘s8’
> DES_bs_b.c:1623:3: error: expected ‘;’ before ‘s1’
> DES_bs_b.c:1627:3: error: expected ‘;’ before ‘s2’
> DES_bs_b.c:1631:3: error: expected ‘;’ before ‘s3’
> DES_bs_b.c:1635:3: error: expected ‘;’ before ‘s4’
> DES_bs_b.c:1639:3: error: expected ‘;’ before ‘s5’
> DES_bs_b.c:1643:3: error: expected ‘;’ before ‘s6’
> DES_bs_b.c:1647:3: error: expected ‘;’ before ‘s7’
> DES_bs_b.c:1651:3: error: expected ‘;’ before ‘s8’
> make[1]: *** [DES_bs_b.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [linux-x86-64-gpu] Error 2
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
