Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <02c401cd3c4b$f4f393f0$dedabbd0$@net>
Date: Sun, 27 May 2012 16:01:58 -0500
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: memory usage within JtR and possible ways to significantly reduce it.

Here is the simple change to get the get_source function working properly in
self test.  In the self-test code, I was able to pass the salt. I believe
the logic will be that if salt pointer is non null, then that data will be
used.  Otherwise if the salt pointer is null, then the data from the last
(current) call from set_salt will be the data to use when rebuilding a
salted hash.

I have not done a salted hash just yet, Once I do a couple salted hashes (I
will likely start by doing most of the dynamic's), then I will for sure that
these methods work the way I think they will.

Jim.


From: jfoug [mailto:jfoug@....net]
>
>>From: magnum [mailto:john.magnum@...hmail.com]
>>We need to add self tests for this,
>
>Agreed.  That has not been put in place,  but must be done.

Download attachment "JtR-get-source-self-test-fix.diff" of type "application/octet-stream" (1026 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.