[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4E2B5C6D.1050102@bredband.net>
Date: Sun, 24 Jul 2011 01:42:37 +0200
From: magnum <rawsmooth@...dband.net>
To: john-dev@...ts.openwall.com
Subject: Re: Plugin formats "released"
On 2011-07-23 23:15, Solar Designer wrote:
> The dependency on GNU make is nasty,
> but it is tricky and maybe unreasonable to avoid it (e.g., running a
> configure script before make wouldn't be obviously better).
It worked on Solaris' make before the changes you did (explanation below).
> So, I started with john-1.7.8-jumbo-2-plugin.diff (yes, I didn't use the
> tarball), did the renames with rename(1) (moved files _not_ to be
> renamed to a subdirectory temporarily), made sure things worked for me
I forgot to explain that, but like Jim just said it's all about
auto-load order. I'm not very happy with "NETSPLITLM" as file name (for
NETHALFLM format), but I couldn't come up with any better that would
load before NETLM. Apart from auto-load order, the file names does not
change anything in the resulting binary (format label etc. is still
NETHALFLM).
> I did not understand the rationale behind some of:
>
> # Should work on Solaris and gmake
> PLUGFORMATS_SRCS: sh =if [ -f *_plug.c ]; then ls *_plug.c; fi
> PLUGFORMATS_SRCS += $(shell ls *_plug.c)
> PLUGFORMATS_OBJS = $(PLUGFORMATS_SRCS:.c=.o)
The comment should better have been "DOES work on Solaris make and
gmake". The first line is a no-op (or empty result or whatever) on gmake
but it does make this work on Solaris make!
> So I simplified it to:
>
> # Requires GNU make (under Solaris, use "gmake")
> PLUGFORMATS_SRCS = $(wildcard *_plug.c)
> PLUGFORMATS_OBJS = $(PLUGFORMATS_SRCS:.c=.o)
You reverted it to my first version that really requires gmake. Jim came
up with the Solaris-compatible way and tested it.
> Then, I did not like the grep|sed|awk commands, which I simplified to
> single invocations of sed:
Fine with me!
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
