Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110721172950.GB3119@openwall.com>
Date: Thu, 21 Jul 2011 21:29:50 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: zip patch omp support

Dhiru -

On Thu, Jul 21, 2011 at 05:43:06PM +0530, Dhiru Kholia wrote:
> Applies on top of JtR 1.7.8-jumbo-2 patchset.

Upon a closer look, it is not clear to me why you require OpenSSL 1.0+
for OpenMP.  We needed to do this for SSH keys because the specific
OpenSSL interfaces you were using were not thread-safe in older versions
of OpenSSL, but you do not appear to be using any such interfaces here.

I think we should try removing those checks and testing the code with
OpenMP on OpenSSL 0.9.7.  I think it'll work just fine.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.