[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200715215607.GA25790@altlinux.org>
Date: Thu, 16 Jul 2020 00:56:07 +0300
From: "Dmitry V. Levin" <ldv@...linux.org>
To: owl-dev@...ts.openwall.com
Subject: Re: [PATCH 0/5] pam_tcb update
On Wed, Jul 15, 2020 at 08:55:39PM +0200, Solar Designer wrote:
[...]
> I've just test-built tcb 1.1.9.1 on Owl for i686, got some warnings:
>
> support.c: In function 'unix_run_helper_binary':
> support.c:330:3: warning: pointer targets in passing argument 1 of 'execve' differ in signedness [-Wpointer-sign]
> /usr/include/unistd.h:480:12: note: expected 'const char *' but argument is of type 'const unsigned char *'
> support.c: In function 'check_crypt':
> support.c:406:6: warning: pointer targets in passing argument 1 of 'crypt_gensalt_ra' differ in signedness [-Wpointer-sign]
> /usr/include/ow-crypt.h:39:14: note: expected 'const char *' but argument is of type 'const unsigned char *'
> support.c: In function 'do_crypt':
> support.c:700:6: warning: pointer targets in passing argument 1 of 'crypt_gensalt_ra' differ in signedness [-Wpointer-sign]
> /usr/include/ow-crypt.h:39:14: note: expected 'const char *' but argument is of type 'const unsigned char *'
> support.c: In function '_set_ctrl':
> support.c:842:30: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
> support.c:845:31: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
> support.c:849:24: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
>
> Will you look into these, please?
These -Wpointer-sign warnings look harmless.
I suppose they are quite old, though.
I've committed a fix.
I also see the following warnings:
nss.c:111:3: warning: 'readdir_r' is deprecated [-Wdeprecated-declarations]
tcb_unconvert.c:245:2: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
tcb_chkpwd.c:58:4: warning: ignoring return value of 'seteuid', declared with attribute warn_unused_result [-Wunused-result]
tcb_chkpwd.c:61:4: warning: ignoring return value of 'seteuid', declared with attribute warn_unused_result [-Wunused-result]
We probably should use readdir instead of readdir_r, this would fix the
first warning.
There is not much we could do about -Wunused-result warnings.
In case of 'chown' it make sense to issue a warning.
In case of first 'seteuid' error we could skip the second 'seteuid'
invocation.
--
ldv
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
