Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPLrYES81vC4s0CNGnGbVscaBRZkMhB3=HujA_kcN7v638RYqg@mail.gmail.com>
Date: Mon, 18 Jun 2012 18:46:51 +0200
From: Daniel Cegiełka <daniel.cegielka@...il.com>
To: owl-dev@...ts.openwall.com
Subject: procps-3.2.8

Hi,

I try to prepare an update owl patches to procps-3.2.8., but I'm a bit
confused. We have in procps-3.2.5-owl-proc.diff:


diff -urk.orig procps-3.2.5.orig/proc/sysinfo.c procps-3.2.5/proc/sysinfo.c
--- procps-3.2.5.orig/proc/sysinfo.c	2005-08-30 12:25:06 +0000
+++ procps-3.2.5/proc/sysinfo.c	2005-08-30 13:19:36 +0000

(...)

@@ -52,7 +47,7 @@
 #define FILE_TO_BUF(filename, fd) do{				\
     static int local_n;						\
     if (fd == -1 && (fd = open(filename, O_RDONLY)) == -1) {	\
-	fprintf(stderr, "%s", BAD_OPEN_MESSAGE);		\
+	checkproc(0);						\
 	fflush(NULL);						\
 	_exit(102);						\
     }			


and then in procps-3.2.5-owl-format.diff:

diff -urk.orig procps-3.2.5.orig/proc/sysinfo.c procps-3.2.5/proc/sysinfo.c
--- procps-3.2.5.orig/proc/sysinfo.c	2005-08-30 13:44:12 +0000
+++ procps-3.2.5/proc/sysinfo.c	2005-08-30 13:44:24 +0000
@@ -52,7 +52,7 @@
 #define FILE_TO_BUF(filename, fd) do{				\
     static int local_n;						\
     if (fd == -1 && (fd = open(filename, O_RDONLY)) == -1) {	\
-	fprintf(stderr, BAD_OPEN_MESSAGE);			\
+	fprintf(stderr, "%s", BAD_OPEN_MESSAGE);		\
 	fflush(NULL);						\
 	_exit(102);						\
     }			


Should I write "fprintf(stderr, "%s", BAD_OPEN_MESSAGE);\" or
"checkproc(0); \" or both???

In a few days I will try to send a whole...

Best regards,
Daniel

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.