Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110316235911.GE16653@drozd.smutek.pl>
Date: Thu, 17 Mar 2011 00:59:11 +0100
From: Piotr Meyer <aniou@...tek.pl>
To: owl-dev@...ts.openwall.com
Subject: Re: VLANs in Owl way?

On Thu, Mar 17, 2011 at 02:15:40AM +0300, Solar Designer wrote:
 
> Why are you commenting out the default route setup?  This change looks
> wrong to me.

Because, when GATEWAY and GATEWAYDEV are set in /etc/sysconfig/network
then commented lines adds gw to any interface. In original code problem
wasn't exists because /etc/sysconfig/network was included after those
lines. But vlan code relies on presence keyword VLAN in 'network' file,
and /etc/sysconfig/network must be included from beginning...

As far I understood this code adds per-interface gateways, I was sugested
by 'this is broken (...)' sentence and because following lines[1] provides
support for default gw in RHEL-way and in RHEL3 I don't found nothing like
this I decided to comment-out those lines.

If this code is essential I can use ipcalc to test availability of gateway
IP via actual network or something in this style...

1 -

    if [ "${GATEWAYDEV}" = "" -o "${GATEWAYDEV}" = "${DEVICE}" ]; then
        # set up default gateway
    [...]

-- 
Piotr 'aniou' Meyer

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.