[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20261027200619.GK23438@brightrain.aerifal.cx>
Date: Tue, 27 Oct 2026 16:06:19 -0400
From: Rich Felker <dalias@...c.org>
To: Colin Cross <ccross@...roid.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] Remove NO_LEGACY_INITFINI
On Tue, Oct 27, 2026 at 11:12:10AM -0700, Colin Cross wrote:
> NO_LEGACY_INITFINI was added in 1da53dad ("disable legacy init/fini
> processing on ARM") because crt/arm/crti.s was running the init/fini
> arrays from _init/_fini, which caused the init/fini arrays to be run
> twice after e69ae844 ("add support for init_array/fini_array
> ctors/dtors to dynamic linker").
>
> NO_LEGACY_INITFINII is no longer necessary after 976c0fdc ("remove
> init/fini array asm from arm crti/crtn files"). Keeping it enabled on
This is not the case. crti/crtn are *linked into binaries* not part of
libc.so. With your patch applied, any binary predating
NO_LEGACY_INITFINI would now be subject to double-init.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
