[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <874ijiukzn.fsf@igalia.com>
Date: Thu, 04 Jun 2026 21:08:28 +0100
From: Luis Henriques <luis@...lia.com>
To: Rich Felker <dalias@...c.org>
Cc: musl@...ts.openwall.com
Subject: Re: [RFC PATCH 0/6] Add new Linux mount API wrappers
On Thu, Jun 04 2026, Rich Felker wrote:
> On Fri, May 29, 2026 at 06:10:57PM +0100, Luis Henriques wrote:
>> This is a set of patches that add the needed wrappers for the new Linux
>> mount API, which has been merged into the 5.2 kernel. Sending them as an
>> RFC as these are my first patches to musl, so it's quite likely that I'm
>> doing something wrong.
>>
>> For reference, here's the list of kernel commits that introduced these new
>> syscalls:
>>
>> a07b20004793 ("vfs: syscall: Add open_tree(2) to reference or clone a mount")
>> 2db154b3ea8e ("vfs: syscall: Add move_mount(2) to move mounts around")
>> 24dcb3d90a1f ("vfs: syscall: Add fsopen() to prepare for superblock creation")
>> ecdab150fddb ("vfs: syscall: Add fsconfig() for configuring and managing a context")
>> 93766fbd2696 ("vfs: syscall: Add fsmount() to create a mount for a superblock")
>> cf3cba4a429b ("vfs: syscall: Add fspick() to select a superblock for reconfiguration")
>
> I didn't see anything particularly "wrong". Since this set of
> interfaces is unlikely to be used alongside mount() though, I'd rather
> not have it in mount.c and linked whenever that is, but in a new file.
> Normally we maximally separate TUs, but this doesn't scale well with
> lots of new thin syscall wrappers like this, so just one file with
> them all in it, added as a single commit, would be fine.
>
> If it's not a big inconvenience, sending groups of patches as
> attachments to a single mail rather than a lkml/git-send-email thread
> is also preferable. It makes it possible to respond to and discuss
> them as a group rather than branching off sub threads for each one.
> But it's not a big deal either way.
Thanks a lot for the feedback, Rich. I'll follow your suggestions and
resend these wrappers soon (over the weekend, most probably).
Cheers,
--
Luís
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
