Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250706213149.GJ288056@port70.net>
Date: Sun, 6 Jul 2025 23:31:49 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: Damian McGuckin <damianm@....com.au>
Cc: MUSL <musl@...ts.openwall.com>
Subject: Re: Comment in ccosh()

* Damian McGuckin <damianm@....com.au> [2025-07-02 15:17:20 +1000]:

> 
> There is a comment in ccoshf()
> 
> 	 /* x < 88.7: expf(|x|) won't overflow */
> 
> where is correct
> 
> The equivalent in ccosh() which says:
> 
> 	/* x < 710: exp(|x|) won't overflow */
> 
> This is far less concise than the earlier case.  More strictly
> 
> 	 /* x < 709.78: exp(|x|) won't overflow */
> 
> Am I being overly pedantic?

i guess the comment is sloppy

i think if you submit such a patch it can be accepted.

(or reword it in another way so it is not actually false)

> 
> Thanks - Damian

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.