Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aFI7Bz3gH6v2g77l@pie>
Date: Wed, 18 Jun 2025 04:05:27 +0000
From: Yao Zi <ziyao@...root.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] time.h: drop non-standard and out-of-date CLOCK_SGI_CYCLE

On Thu, Apr 03, 2025 at 10:10:32AM +0000, Yao Zi wrote:
> This definition was introduced in commit d74e462a ("add CLOCK_TAI (and
> CLOCK_SGI_CYCLE) clock ids to time.h added in linux-v3.10 commit
> 1ff3c9677bff7e468e0c487d0ffefe4e901d33f4"). However, it's actually a
> platform specific feature, available only on SGI SN2 IA64 systems. Its
> Linux support has been removed later in commit 07903ada9613
> ("mmtimer: Remove the SGI SN2 mmtimer driver").
> 
> Having this definition is known to cause applications misdetect the
> environment. There's no reason to keep a non-standard, seldom-available
> and removed-since-4.13-kernel macro in a standard header.
> 
> Signed-off-by: Yao Zi <ziyao@...root.org>

Ping on this patch, thanks for your time and review.

Best regards,
Yao Zi

> ---
> 
> Changed from RFC v1
> - No changes, just resend as a formal patch ready for applying
> - Link to RFC v1: https://www.openwall.com/lists/musl/2024/11/21/6
> 
>  include/time.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/time.h b/include/time.h
> index 3d948372..0fe02111 100644
> --- a/include/time.h
> +++ b/include/time.h
> @@ -94,7 +94,6 @@ struct itimerspec {
>  #define CLOCK_BOOTTIME           7
>  #define CLOCK_REALTIME_ALARM     8
>  #define CLOCK_BOOTTIME_ALARM     9
> -#define CLOCK_SGI_CYCLE         10
>  #define CLOCK_TAI               11
>  
>  #define TIMER_ABSTIME 1
> -- 
> 2.49.0
> 

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.