[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250320134718.GG1827@brightrain.aerifal.cx>
Date: Thu, 20 Mar 2025 09:47:18 -0400
From: Rich Felker <dalias@...c.org>
To: Anders Svensson <anders.otp@...il.com>
Cc: musl@...ts.openwall.com
Subject: Re: strerror_l() segfault
On Thu, Mar 20, 2025 at 11:39:17AM +0100, Anders Svensson wrote:
> I recently noticed a case [1] in which zfs diff segfaults for me on
> Alpine 3.21.3 (musl 1.2.5), and then noticed that it didn't seem to
> have anything to do with zfs: this little test utility, reproducing
> the call zfs-2.2.7 was making, segfaults on both Alpine and Void/musl:
>
> #include <errno.h>
> #include <string.h>
> #include <locale.h>
> #include <assert.h>
>
> int main(int argc, char **argv) {
> locale_t loc = uselocale(0);
> assert(loc != 0);
> char *err = strerror_l(ENOENT, loc); /* segfaults here */
> return 0;
> }
>
> I read [2] that "Locale support is very limited, and barely works", so
> should I just file this failure under that heading or is strerror_l()
> unexpectedly broken? There doesn't seem to be anything wrong with how
> zfs is using it, but I'm no expert.
If you have not set a thread-local locale with uselocale, loc is equal
to LC_GLOBAL_LOCALE, which is not a valid argument to the *_l
functions per POSIX. There's been some discussion of this and I think
the current understanding is that most (all?) other implementations do
accept LC_GLOBAL_LOCALE here, and that it's necessary to do so for the
API to actually be usable, and that POSIX needs to adopt this
requirement. So musl will probably be adding this.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
