[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <082155aa-7166-35ae-f272-53fb7fd55413@ispras.ru>
Date: Sat, 23 Nov 2024 11:30:19 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
cc: Alex Rønne Petersen <alex@...xrp.com>
Subject: Re: [PATCH] s390x: Mark __tls_get_addr hidden before invoking
it.
On Sat, 23 Nov 2024, Alex Rønne Petersen wrote:
> Similar to what's done for __syscall_ret, __sigsetjmp_tail, etc. This fixes a
> linker error when building musl libc.so with zig cc.
Hm, on s390 __tls_get_addr is not used for TLS ABI, so it's fine that it ends up
hidden in libc.so. Unusual.
(linkers must take the most restrictive visibility from all mentions of a symbol)
I'm curious, what kind of error with zig cc were you seeing?
Thanks.
Alexander
> ---
> src/thread/s390x/__tls_get_offset.s | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/thread/s390x/__tls_get_offset.s b/src/thread/s390x/__tls_get_offset.s
> index 8ee92de8..2e0913cc 100644
> --- a/src/thread/s390x/__tls_get_offset.s
> +++ b/src/thread/s390x/__tls_get_offset.s
> @@ -5,6 +5,7 @@ __tls_get_offset:
> aghi %r15, -160
>
> la %r2, 0(%r2, %r12)
> +.hidden __tls_get_addr
> brasl %r14, __tls_get_addr
>
> ear %r1, %a0
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
