[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241022163627.GR10433@brightrain.aerifal.cx>
Date: Tue, 22 Oct 2024 12:36:29 -0400
From: Rich Felker <dalias@...c.org>
To: Alyssa Ross <hi@...ssa.is>
Cc: Szabolcs Nagy <nsz@...t70.net>, musl@...ts.openwall.com
Subject: Re: [PATCH libc-test v3] functional: add mntent test
On Tue, Oct 22, 2024 at 02:12:52PM +0200, Alyssa Ross wrote:
> Szabolcs Nagy <nsz@...t70.net> writes:
>
> > * Alyssa Ross <hi@...ssa.is> [2024-10-19 20:16:39 +0200]:
> >> This only checks reading an fstab from an stream. I haven't written
> >> tests for setmntent(), addmntent(), or hasmntnent().
> >>
> >> test_getmntent exposes a bug in musl 1.2.3 where lines omitting the
> >> final two fields, which are supposed to be optional according to
> >> fstab(5), are not accepted. It also exposes a current bug, where if
> >> the numeric fields are omitted, the last field seen will have a
> >> newline appended to its value. The tests all pass on Glibc.
> >> ---
> >> v3: updated description for current musl
> >> v2: https://inbox.vuxu.org/musl/20210821085420.474615-3-hi@alyssa.is/
> >>
> >> Previously I had a second, optional patch, that would have tested the
> >> behavior of a single-field mntent entry. I've dropped that one, because
> >> musl chose not to match Glibc in accepting it.
> >>
> >
> > patch looks ok. it fails with
> >
> > src/functional/mntent.c:47: !strcmp(m->mnt_opts, "defaults") failed
> > FAIL src/functional/mntent-static.exe [status 1]
> > src/functional/mntent.c:47: !strcmp(m->mnt_opts, "defaults") failed
> > FAIL src/functional/mntent.exe [status 1]
> >
> > i guess this should be fixed
>
> Fix has already been submitted here:
> https://inbox.vuxu.org/musl/20241019181320.23977-2-hi@alyssa.is/
>
> I think it should pass on musl 1.2.4.
Yep, thanks. I'll get this and some other new stuff committed.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
