[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240902210235.GT10433@brightrain.aerifal.cx>
Date: Mon, 2 Sep 2024 17:02:35 -0400
From: Rich Felker <dalias@...c.org>
To: Jesse Taube <mr.bossman075@...il.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] arch/riscv*/atomic_arch.h: Check if atomic is
supported
On Mon, Sep 02, 2024 at 03:56:14PM -0400, Jesse Taube wrote:
> Define a_cas and a_cas_p only if atomic instructions are supported.
>
> Signed-off-by: Jesse Taube <Mr.Bossman075@...il.com>
> ---
> arch/riscv32/atomic_arch.h | 4 ++++
> arch/riscv64/atomic_arch.h | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/riscv32/atomic_arch.h b/arch/riscv32/atomic_arch.h
> index 4d418f63..331ce46e 100644
> --- a/arch/riscv32/atomic_arch.h
> +++ b/arch/riscv32/atomic_arch.h
> @@ -4,6 +4,8 @@ static inline void a_barrier()
> __asm__ __volatile__ ("fence rw,rw" : : : "memory");
> }
>
> +#if defined(__riscv_a) || defined(__riscv_atomic)
> +
> #define a_cas a_cas
> static inline int a_cas(volatile int *p, int t, int s)
> {
> @@ -19,3 +21,5 @@ static inline int a_cas(volatile int *p, int t, int s)
> : "memory");
> return old;
> }
> +
> +#endif
> diff --git a/arch/riscv64/atomic_arch.h b/arch/riscv64/atomic_arch.h
> index 0c382588..dac972d2 100644
> --- a/arch/riscv64/atomic_arch.h
> +++ b/arch/riscv64/atomic_arch.h
> @@ -4,6 +4,8 @@ static inline void a_barrier()
> __asm__ __volatile__ ("fence rw,rw" : : : "memory");
> }
>
> +#if defined(__riscv_a) || defined(__riscv_atomic)
> +
> #define a_cas a_cas
> static inline int a_cas(volatile int *p, int t, int s)
> {
> @@ -36,3 +38,5 @@ static inline void *a_cas_p(volatile void *p, void *t, void *s)
> : "memory");
> return old;
> }
> +
> +#endif
> --
> 2.45.2
These are a hard dependency. You can't just omit them. The build will
fail elsewhere without them, not to mention stuff blowing up at
runtime.
What is the actual problem you're trying to solve?
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
