[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<CH3PR02MB10247E03891A370B0721648E1B8812@CH3PR02MB10247.namprd02.prod.outlook.com>
Date: Fri, 16 Aug 2024 20:27:30 +0000
From: Brian Cain <bcain@...cinc.com>
To: Arnd Bergmann <arnd@...nel.org>,
"linux-arch@...r.kernel.org"
<linux-arch@...r.kernel.org>,
"linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
CC: Arnd Bergmann <arnd@...db.de>,
Thomas Bogendoerfer
<tsbogend@...ha.franken.de>,
"linux-mips@...r.kernel.org"
<linux-mips@...r.kernel.org>,
Helge Deller <deller@....de>,
"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
"David S.
Miller" <davem@...emloft.net>,
Andreas Larsson <andreas@...sler.com>,
"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
Michael Ellerman
<mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy
<christophe.leroy@...roup.eu>,
"Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
Guo Ren
<guoren@...nel.org>,
"linux-csky@...r.kernel.org"
<linux-csky@...r.kernel.org>,
Heiko Carstens <hca@...ux.ibm.com>,
"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
Rich Felker
<dalias@...c.org>,
John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
"H. Peter Anvin"
<hpa@...or.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner
<brauner@...nel.org>,
"linux-fsdevel@...r.kernel.org"
<linux-fsdevel@...r.kernel.org>,
"libc-alpha@...rceware.org"
<libc-alpha@...rceware.org>,
"musl@...ts.openwall.com"
<musl@...ts.openwall.com>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v2 09/13] csky, hexagon: fix broken sys_sync_file_range
> -----Original Message-----
> From: Arnd Bergmann <arnd@...nel.org>
> Sent: Monday, June 24, 2024 11:37 AM
> To: linux-arch@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>; Thomas Bogendoerfer
> <tsbogend@...ha.franken.de>; linux-mips@...r.kernel.org; Helge Deller
> <deller@....de>; linux-parisc@...r.kernel.org; David S. Miller
> <davem@...emloft.net>; Andreas Larsson <andreas@...sler.com>;
> sparclinux@...r.kernel.org; Michael Ellerman <mpe@...erman.id.au>; Nicholas
> Piggin <npiggin@...il.com>; Christophe Leroy
> <christophe.leroy@...roup.eu>; Naveen N . Rao
> <naveen.n.rao@...ux.ibm.com>; linuxppc-dev@...ts.ozlabs.org; Brian Cain
> <bcain@...cinc.com>; linux-hexagon@...r.kernel.org; Guo Ren
> <guoren@...nel.org>; linux-csky@...r.kernel.org; Heiko Carstens
> <hca@...ux.ibm.com>; linux-s390@...r.kernel.org; Rich Felker
> <dalias@...c.org>; John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>;
> linux-sh@...r.kernel.org; H. Peter Anvin <hpa@...or.com>; Alexander Viro
> <viro@...iv.linux.org.uk>; Christian Brauner <brauner@...nel.org>; linux-
> fsdevel@...r.kernel.org; libc-alpha@...rceware.org;
> musl@...ts.openwall.com; stable@...r.kernel.org
> Subject: [PATCH v2 09/13] csky, hexagon: fix broken sys_sync_file_range
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> From: Arnd Bergmann <arnd@...db.de>
>
> Both of these architectures require u64 function arguments to be
> passed in even/odd pairs of registers or stack slots, which in case of
> sync_file_range would result in a seven-argument system call that is
> not currently possible. The system call is therefore incompatible with
> all existing binaries.
>
> While it would be possible to implement support for seven arguments
> like on mips, it seems better to use a six-argument version, either
> with the normal argument order but misaligned as on most architectures
> or with the reordered sync_file_range2() calling conventions as on
> arm and powerpc.
>
> Cc: stable@...r.kernel.org
> Acked-by: Guo Ren <guoren@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> arch/csky/include/uapi/asm/unistd.h | 1 +
> arch/hexagon/include/uapi/asm/unistd.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/csky/include/uapi/asm/unistd.h
> b/arch/csky/include/uapi/asm/unistd.h
> index 7ff6a2466af1..e0594b6370a6 100644
> --- a/arch/csky/include/uapi/asm/unistd.h
> +++ b/arch/csky/include/uapi/asm/unistd.h
> @@ -6,6 +6,7 @@
> #define __ARCH_WANT_SYS_CLONE3
> #define __ARCH_WANT_SET_GET_RLIMIT
> #define __ARCH_WANT_TIME32_SYSCALLS
> +#define __ARCH_WANT_SYNC_FILE_RANGE2
> #include <asm-generic/unistd.h>
>
> #define __NR_set_thread_area (__NR_arch_specific_syscall + 0)
> diff --git a/arch/hexagon/include/uapi/asm/unistd.h
> b/arch/hexagon/include/uapi/asm/unistd.h
> index 432c4db1b623..21ae22306b5d 100644
> --- a/arch/hexagon/include/uapi/asm/unistd.h
> +++ b/arch/hexagon/include/uapi/asm/unistd.h
> @@ -36,5 +36,6 @@
> #define __ARCH_WANT_SYS_VFORK
> #define __ARCH_WANT_SYS_FORK
> #define __ARCH_WANT_TIME32_SYSCALLS
> +#define __ARCH_WANT_SYNC_FILE_RANGE2
Acked-by: Brian Cain <bcain@...cinc.com>
>
> #include <asm-generic/unistd.h>
> --
> 2.39.2
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
