Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240722151724.GR3766212@port70.net>
Date: Mon, 22 Jul 2024 17:17:24 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: Brad House <brad@...d-house.com>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH 1/1] FD_SET() and FD_ISSET() warn on
 -Wsign-conversion

* Brad House <brad@...d-house.com> [2024-07-18 11:21:59 -0400]:
> On 7/18/24 9:19 AM, Szabolcs Nagy wrote:
> 
> > the macro argument must be protected with ()
> > e.g. the patch changes behaviour if d is 0.5?x:y
> 
> I'm not sure about your statement above about a behavior change if d is 0.5,
> file descriptors are required to be int, which can't represent 0.5.  Passing
> in a garbage value would clearly fall into "Undefined Behavior".

d is not 0.5 but 0.5?x:y which is an int with int x,y.

but my point was just that you should always put macro args in ().

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.