Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAB_d6t5+Bi1XL7D+xxaYn7R86WYfrDgn-_Z5+gy9nP5zagJ87w@mail.gmail.com>
Date: Fri, 10 May 2024 18:01:58 +0200
From: Florian Ziesche <florian.ziesche@...il.com>
To: musl@...ts.openwall.com
Subject: [PATCH] dynlink: fix get_lfs64() with posix_fallocate64

Hi,

this patch increases the buffer size by one in get_lfs64() so that it
works with posix_fallocate64.
"posix_fallocate64" is 17 characters long, so 16 is one too short.

Simplified example:
before: https://compiler-explorer.com/z/4qcPhcaWr
after: https://compiler-explorer.com/z/scGvhddKW

---
diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index 42687da2..8707ae1c 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -363,7 +363,7 @@ static struct symdef get_lfs64(const char *name)
         "stat\0statfs\0statvfs\0tmpfile\0truncate\0versionsort\0"
         "__fxstat\0__fxstatat\0__lxstat\0__xstat\0";
     size_t l;
-    char buf[16];
+    char buf[17];
     for (l=0; name[l]; l++) {
         if (l >= sizeof buf) goto nomatch;
         buf[l] = name[l];

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.